Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 24168006: Fixing issues from lifecycle events CL (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Fixing analyzer error on legacy custom element polyfill - Adjsuting IE status (filed bug to investigate) - Fixing polymer tests on Dartium BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27846

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-24 20:08:43 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-09-24 20:10:51 UTC) #2
blois
7 years, 3 months ago (2013-09-24 20:11:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698