Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 24166003: Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs." (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs." R=johnniwinther@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27693

Patch Set 1 : Original. #

Patch Set 2 : Fix dart2dart by not creating placeholders. #

Patch Set 3 : Another fix to dart2dart #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 4 chunks +36 lines, -28 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
The original CL in patch set 1 has been reviewed by Nicolas. Patch set 2 ...
7 years, 3 months ago (2013-09-20 08:52:48 UTC) #1
Johnni Winther
lgtm
7 years, 3 months ago (2013-09-20 08:59:29 UTC) #2
karlklose
Forgot a place and the status file.
7 years, 3 months ago (2013-09-20 09:55:55 UTC) #3
karlklose
7 years, 3 months ago (2013-09-20 09:59:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r27693 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698