Issue 24165006: Fix socket_android.cc to agree with socket_linux.cc and compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24165006: Fix socket_android.cc to agree with socket_linux.cc and compile. (Closed)

Created:
7 years, 3 months ago by Bill Hesse

Modified:
7 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix socket_android.cc to agree with socket_linux.cc and compile. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27803

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/socket_android.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Ivan Posva

LGTM Does that mean socket_android.cc was never compiled before? -Ivan

7 years, 3 months ago (2013-09-24 07:28:50 UTC) #2

Bill Hesse

On 2013/09/24 07:28:50, Ivan Posva wrote: > LGTM > > Does that mean socket_android.cc was ...

7 years, 3 months ago (2013-09-24 09:20:11 UTC) #3

Bill Hesse

7 years, 3 months ago (2013-09-24 09:34:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r27803 (presubmit successful).