Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2416003003: Update package name, update and lock clang-format and tslint versions, and format all source files … (Closed)

Created:
4 years, 2 months ago by Jacob
Modified:
4 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update package name, update and lock clang-format and tslint versions, and format all source files to match. BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/js_facade_gen/commit/1d3b15dcdb3fbefbad7160ca3dd851ba32f4ffbb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use ES6 Map and Set instead of Object literals to avoid ordering instability across different Node … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -100 lines) Patch
M lib/base.ts View 1 6 chunks +8 lines, -13 lines 0 comments Download
M lib/declaration.ts View 1 5 chunks +8 lines, -7 lines 0 comments Download
M lib/facade_converter.ts View 1 10 chunks +27 lines, -26 lines 0 comments Download
M lib/main.ts View 1 6 chunks +7 lines, -8 lines 0 comments Download
M lib/merge.ts View 1 16 chunks +32 lines, -35 lines 0 comments Download
M test/facade_converter_test.ts View 1 2 chunks +0 lines, -3 lines 0 comments Download
M test/test_support.ts View 1 3 chunks +8 lines, -4 lines 0 comments Download
M tsconfig.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M tsd.json View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jacob
4 years, 2 months ago (2016-10-14 17:00:09 UTC) #2
kevmoo
Can we delete the e2e test? Let's nuke the code and dependencies – and add ...
4 years, 2 months ago (2016-10-14 17:02:33 UTC) #3
Jacob
Committed patchset #1 (id:1) manually as 1d3b15dcdb3fbefbad7160ca3dd851ba32f4ffbb (presubmit successful).
4 years, 2 months ago (2016-10-14 19:31:38 UTC) #5
kevmoo
On 2016/10/14 19:31:38, Jacob wrote: > Committed patchset #1 (id:1) manually as > 1d3b15dcdb3fbefbad7160ca3dd851ba32f4ffbb (presubmit ...
4 years, 2 months ago (2016-10-14 19:40:50 UTC) #6
Jacob
4 years, 2 months ago (2016-10-15 01:08:14 UTC) #7
Message was sent while issue was closed.
On 2016/10/14 19:40:50, kevmoo wrote:
> On 2016/10/14 19:31:38, Jacob wrote:
> > Committed patchset #1 (id:1) manually as
> > 1d3b15dcdb3fbefbad7160ca3dd851ba32f4ffbb (presubmit successful).
> 
> Uh...see my comments? :-)

Uh... fixed your comments. :)

Powered by Google App Engine
This is Rietveld 408576698