Support "D" for ordinal date in Intl.DateFormat

Support "D" for ordinal date in Intl.DateFormat

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27840

[Alan Knight, 2013-09-18 19:39:11]

dartbug.com/13385

[Emily Fortuna, 2013-09-23 19:48:27]

https://codereview.chromium.org/24156005/diff/1/pkg/intl/lib/src/date_format_...
File pkg/intl/lib/src/date_format_field.dart (right):

https://codereview.chromium.org/24156005/diff/1/pkg/intl/lib/src/date_format_...
pkg/intl/lib/src/date_format_field.dart:381: * underlying calculation, even
though it doesn't expose the test to us. */
nit end the */ on its own line

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:373: Map<int, DateTime>
generateDates(int year, int leapDay) =>
a little comment here explaining this function would be nice

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:374: new Iterable.generate(365 +
leapDay, (n) => n + 1)
+2 spaces indent

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:381: var formatted =
f.format(date);
I think this should just be +2 spaces indentation

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:395: // Check one hard-coded just
to be on the safe side
nit: end in a "."

[Emily Fortuna, 2013-09-23 19:48:56]

lgtm after the edits. sorry for the slow review.

[Alan Knight, 2013-09-24 19:13:34]

Committed patchset #2 manually as r27840 (presubmit successful).

[Alan Knight, 2013-09-25 17:17:58]

https://codereview.chromium.org/24156005/diff/1/pkg/intl/lib/src/date_format_...
File pkg/intl/lib/src/date_format_field.dart (right):

https://codereview.chromium.org/24156005/diff/1/pkg/intl/lib/src/date_format_...
pkg/intl/lib/src/date_format_field.dart:381: * underlying calculation, even
though it doesn't expose the test to us. */
On 2013/09/23 19:48:27, Emily Fortuna wrote:
> nit end the */ on its own line

Done.

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:373: Map<int, DateTime>
generateDates(int year, int leapDay) =>
On 2013/09/23 19:48:27, Emily Fortuna wrote:
> a little comment here explaining this function would be nice

Done.

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:374: new Iterable.generate(365 +
leapDay, (n) => n + 1)
On 2013/09/23 19:48:27, Emily Fortuna wrote:
> +2 spaces indent

Done.

https://codereview.chromium.org/24156005/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:381: var formatted =
f.format(date);
On 2013/09/23 19:48:27, Emily Fortuna wrote:
> I think this should just be +2 spaces indentation

Done.