Issue 24153008: Check if signatures are compatible in a redirecting factory before synthesizing a call in the infer…

Issue 24153008: Check if signatures are compatible in a redirecting factory before synthesizing a call in the infer… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check if signatures are compatible in a redirecting factory before synthesizing a call in the inferrer. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27596

Patch Set 10 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -14 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2 3 4 5 6 7 8	1 chunk	+13 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2 3 4 5 6 7	3 chunks	+9 lines, -3 lines	0 comments	Download
A	tests/language/redirecting_factory_incompatible_signature_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Thanks Karl, PTAL, I had to change the implementation of FunctionSignature.isCompatibleWith.

7 years, 3 months ago (2013-09-18 06:57:51 UTC) #3

karlklose

SLGTM. https://codereview.chromium.org/24153008/diff/26001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/24153008/diff/26001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1215 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1215: int otherCount = signature.parameterCount; 'otherCount' -> 'otherTotalCount'?

7 years, 3 months ago (2013-09-18 07:54:42 UTC) #4

ngeoffray

Thanks Karl. https://codereview.chromium.org/24153008/diff/26001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/24153008/diff/26001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1215 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1215: int otherCount = signature.parameterCount; On 2013/09/18 07:54:42, ...

7 years, 3 months ago (2013-09-18 08:00:45 UTC) #5

ngeoffray

7 years, 3 months ago (2013-09-18 08:48:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #10 manually as r27596 (presubmit successful).

Expand Messages | Collapse Messages