Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 241483003: Add fuzz test for reflective invocation. (Closed)

Created:
6 years, 8 months ago by rmacnak
Modified:
6 years, 8 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add fuzz test for reflective invocation. B=http://dartbug.com/15274 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=35155

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -0 lines) Patch
M tests/lib/lib.status View 2 chunks +2 lines, -0 lines 0 comments Download
A tests/lib/mirrors/invoke_natives_fuzz_test.dart View 1 chunk +135 lines, -0 lines 2 comments Download
A tests/lib/mirrors/invoke_natives_malicious_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
6 years, 8 months ago (2014-04-17 21:00:28 UTC) #1
gbracha
lgtm with comment. https://codereview.chromium.org/241483003/diff/40001/tests/lib/mirrors/invoke_natives_fuzz_test.dart File tests/lib/mirrors/invoke_natives_fuzz_test.dart (right): https://codereview.chromium.org/241483003/diff/40001/tests/lib/mirrors/invoke_natives_fuzz_test.dart#newcode86 tests/lib/mirrors/invoke_natives_fuzz_test.dart:86: new List(m.parameters.length)); So if the constructor ...
6 years, 8 months ago (2014-04-17 21:25:28 UTC) #2
rmacnak
https://codereview.chromium.org/241483003/diff/40001/tests/lib/mirrors/invoke_natives_fuzz_test.dart File tests/lib/mirrors/invoke_natives_fuzz_test.dart (right): https://codereview.chromium.org/241483003/diff/40001/tests/lib/mirrors/invoke_natives_fuzz_test.dart#newcode86 tests/lib/mirrors/invoke_natives_fuzz_test.dart:86: new List(m.parameters.length)); On 2014/04/17 21:25:28, gbracha wrote: > So ...
6 years, 8 months ago (2014-04-17 21:47:19 UTC) #3
rmacnak
6 years, 8 months ago (2014-04-17 21:48:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698