Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 24129004: fix shadowdom polyfill (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix shadowdom polyfill I'm not sure when it broke, but it was not rendering TodoMVC at startup (actually -- it was rendering, then clearing). In any case, the bug goes away with an updated ShadowDOM. We're now completely unforked I also fixed minify mode. It no longer depends on the name 'GeneratedWrapper', instead it detects the precise problematic case and deals with it. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=27458

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1650 lines, -251 lines) Patch
M pkg/pkg.status View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.debug.js View 43 chunks +1627 lines, -231 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.min.js View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/shadow_dom/tool/build.sh View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
also fixes https://code.google.com/p/dart/issues/detail?id=13265 https://codereview.chromium.org/24129004/diff/1/pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js File pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js (right): https://codereview.chromium.org/24129004/diff/1/pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js#newcode43 pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js:43: if (ctor === unwrapped.constructor) { Not ...
7 years, 3 months ago (2013-09-12 22:47:00 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/24129004/diff/1/pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js File pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js (right): https://codereview.chromium.org/24129004/diff/1/pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js#newcode43 pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js:43: if (ctor === unwrapped.constructor) { On 2013/09/12 22:47:00, ...
7 years, 3 months ago (2013-09-12 22:49:58 UTC) #2
Jennifer Messerly
7 years, 3 months ago (2013-09-12 23:04:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27458 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698