Issue 241253002: VM Service: Include a response id when enumerating scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 241253002: VM Service: Include a response id when enumerating scripts. (Closed)

Created:
6 years, 8 months ago by rmacnak

Modified:
6 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

VM Service: Include a response id when enumerating scripts. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35146

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/vm/service.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm after removing changes in object.dart https://codereview.chromium.org/241253002/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/241253002/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode566 runtime/bin/vmservice/client/lib/src/service/object.dart:566: remove this

6 years, 8 months ago (2014-04-17 18:11:39 UTC) #2

rmacnak

On 2014/04/17 18:11:39, Cutch wrote: > lgtm after removing changes in object.dart > > https://codereview.chromium.org/241253002/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart ...

6 years, 8 months ago (2014-04-17 18:16:13 UTC) #3

rmacnak

6 years, 8 months ago (2014-04-17 18:16:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35146 (presubmit successful).

Expand Messages | Collapse Messages

Issue 241253002: VM Service: Include a response id when enumerating scripts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages