Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 24125005: Do not evaluate inlined field initializations twice in a redirecting constructor. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not evaluate inlined field initializations twice in a redirecting constructor. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +7 lines, -3 lines 0 comments Download
A tests/language/evaluation_redirecting_constructor_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-16 20:16:18 UTC) #1
kasperl
LGTM.
7 years, 3 months ago (2013-09-17 05:21:19 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-17 07:31:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698