Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 241223005: Fix a deadlock bug with lazy transformer pipelining. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a deadlock bug with lazy transformer pipelining. A deadlock would occur when a lazy primary input to a lazy transformer became dirty while the transformer's apply method was running. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/barback/test/package_graph/lazy_transformer_test.dart View 2 chunks +34 lines, -1 line 0 comments Download
M pkg/barback/test/transformer/declare_assets.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A pkg/barback/test/transformer/lazy_assets.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/barback/test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-17 20:08:30 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-18 17:28:36 UTC) #2
nweiz
6 years, 8 months ago (2014-04-18 20:03:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698