It's not just [] that return the element type of a List. Make the container optimization work for s…

It's not just [] that return the element type of a List. Make the container optimization work for selectors we know return the element type.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27805

[kasperl, 2013-09-24 08:42:22]

lgtm

LGTM. Do you need to extend a test case?

https://codereview.chromium.org/24118004/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/24118004/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:787:
&& returnsElementTypeSet.contains(selector.name.slowToString())) {
Could this be a set of selectors instead? That would be somewhat nicer.

[ngeoffray, 2013-09-24 10:06:50]

Test added. Thanks Kasper.

https://codereview.chromium.org/24118004/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/24118004/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:787:
&& returnsElementTypeSet.contains(selector.name.slowToString())) {
On 2013/09/24 08:42:22, kasperl wrote:
> Could this be a set of selectors instead? That would be somewhat nicer.

I made it consistent with the other sets in container_tracer.dart. As discussed,
I added a helper, and we can think later on how this could be nicer.

[kasperl, 2013-09-24 10:09:55]

Still LGTM.

[ngeoffray, 2013-09-24 10:32:37]

Committed patchset #3 manually as r27805 (presubmit successful).