Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 24114005: Allow getters to return Intl messages (Closed)

Created:
7 years, 3 months ago by Alan Knight
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[ak] Allow getters to return messages R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/intl/lib/extract_messages.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
7 years, 3 months ago (2013-09-11 20:43:17 UTC) #1
Emily Fortuna
lgtm
7 years, 3 months ago (2013-09-11 21:00:26 UTC) #2
Alan Knight
7 years, 3 months ago (2013-09-11 21:15:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698