Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 24113004: Double the default heap size on 64-bit platforms to account for all pointers taking up twice the am… (Closed)

Created:
7 years, 3 months ago by kasperl
Modified:
7 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Double the default heap size on 64-bit platforms to account for all pointers taking up twice the amount of memory. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27466

Patch Set 1 #

Total comments: 2

Patch Set 2 : Avoid ifdef. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/heap.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
7 years, 3 months ago (2013-09-12 10:42:55 UTC) #1
kasperl
We're seeing a few cases where we are running out of memory in dart2js on ...
7 years, 3 months ago (2013-09-12 10:46:41 UTC) #2
Ivan Posva
Please keep the code size where it is. We will need to work out the ...
7 years, 3 months ago (2013-09-13 07:41:07 UTC) #3
kasperl
https://codereview.chromium.org/24113004/diff/1/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/24113004/diff/1/runtime/vm/heap.h#newcode59 runtime/vm/heap.h:59: static const intptr_t kHeapSizeInMB = 512; On 2013/09/13 07:41:08, ...
7 years, 3 months ago (2013-09-13 07:46:22 UTC) #4
kasperl
7 years, 3 months ago (2013-09-13 07:52:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698