Reapply "Convert HashSet, LinkedHashSet to factory methods and custom implementations."

Reapply "Convert HashSet, LinkedHashSet to factory methods and custom implementations."

R=floitsch@google.com, fschneider@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27610

[floitsch, 2013-09-12 13:49:12]

LGTM.

https://codereview.chromium.org/24104003/diff/3001/sdk/lib/collection/hash_se...
File sdk/lib/collection/hash_set.dart (right):

https://codereview.chromium.org/24104003/diff/3001/sdk/lib/collection/hash_se...
sdk/lib/collection/hash_set.dart:52: retainSet = new HashSet(equals:
identical)..addAll(objectsToRetain);
add comment why identical.

[Lasse Reichstein Nielsen, 2013-09-16 13:57:34]

VM/dart2js people, PTAL.

[Lasse Reichstein Nielsen, 2013-09-18 08:56:35]

Updated the retainAll and added tests.

https://codereview.chromium.org/24104003/diff/3001/sdk/lib/collection/hash_se...
File sdk/lib/collection/hash_set.dart (right):

https://codereview.chromium.org/24104003/diff/3001/sdk/lib/collection/hash_se...
sdk/lib/collection/hash_set.dart:52: retainSet = new HashSet(equals:
identical)..addAll(objectsToRetain);
It was to make it work with both equality sets and identity sets, both of which
extend this. It won't work, though. I'll have to use a set of the same type as
this (which I can using _newSet!).

[kasperl, 2013-09-18 09:07:06]

Changes to dart2js code base LGTM.

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
File runtime/lib/collection_patch.dart (right):

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
runtime/lib/collection_patch.dart:560: // Set
Terminate with . Remove newline after comment?

[Florian Schneider, 2013-09-18 09:07:19]

lgtm

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
File runtime/lib/collection_patch.dart (right):

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
runtime/lib/collection_patch.dart:574: _add(element);
Why do you need add and _add when add is just a call to _add?

[floitsch, 2013-09-18 09:32:51]

Still LGTM.

[Lasse Reichstein Nielsen, 2013-09-18 11:35:41]

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
File runtime/lib/collection_patch.dart (right):

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
runtime/lib/collection_patch.dart:560: // Set
As a "separator", I like the newline after. It applies to the entire section
below, not just to the first element, which no newline suggest. Will add '.'.

https://codereview.chromium.org/24104003/diff/22001/runtime/lib/collection_pa...
runtime/lib/collection_patch.dart:574: _add(element);
Good point. It's old habit. 
I prefer not to make one public method depend on another, in case someone
overrides the other method.
In this case it's not important since the class is private, so I'll just have
the "add".

[Lasse Reichstein Nielsen, 2013-09-18 11:36:50]

Committed patchset #6 manually as r27610 (presubmit successful).