PolymerExpressions: fix for null iterators in comprehensions

PolymerExpressions: fix for null iterators in comprehensions

BUG=
R=cbracken@google.com, jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27528

[justinfagnani, 2013-09-16 19:34:17]

On 2013/09/16 19:32:20, justinfagnani wrote:

Bug report: https://code.google.com/p/dart/issues/detail?id=13332

[Chris Bracken, 2013-09-16 19:37:42]

lgtm

[Jennifer Messerly, 2013-09-16 19:43:47]

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:607: : iterable = (iterable != null) ?
iterable : [];
const [] ?

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/test/...
File pkg/polymer_expressions/test/syntax_test.dart (right):

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/test/...
pkg/polymer_expressions/test/syntax_test.dart:19: tearDown(() {
hmm, not sure about this change. Is there a rationale to this? The previous code
seemed better at enforcing the invariants: ensure HTML is added and only the
added HTML is removed.

It did have the downside of hardcoding the HTML snippet though.

Perhaps a pattern more like this?
https://github.com/dart-lang/bleeding_edge/blob/master/dart/pkg/mdv/test/temp...

[justinfagnani, 2013-09-16 20:02:57]

ptal

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:607: : iterable = (iterable != null) ?
iterable : [];
On 2013/09/16 19:43:47, John Messerly wrote:
> const [] ?

Done.

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/test/...
File pkg/polymer_expressions/test/syntax_test.dart (right):

https://codereview.chromium.org/24096016/diff/1/pkg/polymer_expressions/test/...
pkg/polymer_expressions/test/syntax_test.dart:19: tearDown(() {
On 2013/09/16 19:43:47, John Messerly wrote:
> hmm, not sure about this change. Is there a rationale to this? The previous
code
> seemed better at enforcing the invariants: ensure HTML is added and only the
> added HTML is removed.
> 
> It did have the downside of hardcoding the HTML snippet though.
> 
> Perhaps a pattern more like this?
>
https://github.com/dart-lang/bleeding_edge/blob/master/dart/pkg/mdv/test/temp...

Done.

[Jennifer Messerly, 2013-09-16 20:11:05]

lgtm

[justinfagnani, 2013-09-16 20:15:11]

Committed patchset #2 manually as r27528 (presubmit successful).