Issue 24094004: Do not eliminate GuardFieldInstr when guarding list length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24094004: Do not eliminate GuardFieldInstr when guarding list length. (Closed)

Created:
7 years, 3 months ago by Cutch

Modified:
7 years, 2 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google), Florian Schneider

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Do not eliminate GuardFieldInstr when guarding list length. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27420

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Cutch

Committed patchset #1 manually as r27420 (presubmit successful).

7 years, 3 months ago (2013-09-12 07:29:32 UTC) #3

srdjan

7 years, 2 months ago (2013-10-02 00:00:42 UTC) #4

Message was sent while issue was closed.

This CL has caused almost 30% performance degradation on Box2D, ia32 only!
Investigating...