Emit a compile-time error when the name of a variable is referenced in the

Emit a compile-time error when the name of a variable is referenced in the
initializing expression.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27421

[karlklose, 2013-09-10 11:27:10]

This is only a partial implementation of the specification. If we agree to keep
the scopes as specified, we'll have to change our scopes (see issue 13204).

[ngeoffray, 2013-09-10 11:39:48]

LGTM

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/scope.dart (right):

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/scope.dart:58: throw
"Cannot add element to TypeDeclarationScope";
TypeDeclarationScope -> VariableDefinitionScope

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:644: howToFix: "If you
trying to reference a shadowed variable, rename"
If you are

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:646: examples: const["""
space before [.

https://codereview.chromium.org/24091002/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/24091002/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:6: block_scope_test; Fail # Issue 13204.
; -> :

[karlklose, 2013-09-10 11:45:53]

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/scope.dart (right):

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/scope.dart:58: throw
"Cannot add element to TypeDeclarationScope";
On 2013/09/10 11:39:48, ngeoffray wrote:
> TypeDeclarationScope -> VariableDefinitionScope

Done.

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:644: howToFix: "If you
trying to reference a shadowed variable, rename"
On 2013/09/10 11:39:48, ngeoffray wrote:
> If you are

Done.

https://codereview.chromium.org/24091002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:646: examples: const["""
On 2013/09/10 11:39:48, ngeoffray wrote:
> space before [.

Done.

https://codereview.chromium.org/24091002/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/24091002/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:6: block_scope_test; Fail # Issue 13204.
On 2013/09/10 11:39:48, ngeoffray wrote:
> ; -> :

Done.

[karlklose, 2013-09-12 07:45:23]

Committed patchset #4 manually as r27421 (presubmit successful).