Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 24084004: Exposing document.createElement (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Exposing document.createElement As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -162 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 61 chunks +67 lines, -69 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 63 chunks +68 lines, -68 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/safe_dom_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/src/shared_SVGFactoryProviders.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 3 months ago (2013-09-11 16:53:28 UTC) #1
Emily Fortuna
I thought this was part of a larger change? ;-) Or what about making this ...
7 years, 3 months ago (2013-09-11 19:46:09 UTC) #2
blois
On 2013/09/11 19:46:09, Emily Fortuna wrote: > I thought this was part of a larger ...
7 years, 3 months ago (2013-09-11 19:54:27 UTC) #3
Emily Fortuna
alrighty. lgtm.
7 years, 3 months ago (2013-09-11 19:57:54 UTC) #4
blois
7 years, 3 months ago (2013-09-12 00:00:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r27415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698