Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 24082005: Detect asynchronous dart2js crashes correctly. (Closed)

Created:
7 years, 3 months ago by Johnni Winther
Modified:
7 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Detect asynchronous dart2js crashes correctly. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +41 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 3 months ago (2013-09-16 09:17:27 UTC) #1
ahe
LGTM!
7 years, 3 months ago (2013-09-16 14:20:46 UTC) #2
Johnni Winther
7 years, 3 months ago (2013-09-17 06:37:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698