Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 24077003: fix polymer tests -- replace run.sh and run tests using bots (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix polymer tests -- replace run.sh and run tests using bots BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=27353

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -2187 lines) Patch
M pkg/pkg.status View 1 4 chunks +11 lines, -3 lines 0 comments Download
D pkg/polymer/example/component/news/test/expected/news_index_test.html.txt View 1 1 chunk +0 lines, -75 lines 0 comments Download
A pkg/polymer/example/component/news/test/news_index_test.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/polymer/example/component/news/test/news_index_test.html View 1 2 chunks +3 lines, -7 lines 0 comments Download
D pkg/polymer/example/component/news/test/test.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/polymer/lib/src/transform/script_compactor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D pkg/polymer/lib/testing/content_shell_test.dart View 1 1 chunk +0 lines, -226 lines 0 comments Download
D pkg/polymer/lib/testing/testing.js View 1 1 chunk +0 lines, -175 lines 0 comments Download
A + pkg/polymer/test/build/compiler_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/polymer/test/build/css_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/polymer/test/build/linter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/polymer/test/build/testing.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/polymer/test/build/utils_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/polymer/test/compiler_test.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D pkg/polymer/test/css_test.dart View 1 chunk +0 lines, -500 lines 0 comments Download
D pkg/polymer/test/data/unit/web/event_path_test.html View 1 chunk +0 lines, -142 lines 0 comments Download
D pkg/polymer/test/data/unit/web/events_test.html View 1 chunk +0 lines, -97 lines 0 comments Download
A pkg/polymer/test/event_path_test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A pkg/polymer/test/event_path_test.html View 1 chunk +86 lines, -0 lines 0 comments Download
A pkg/polymer/test/events_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A + pkg/polymer/test/events_test.html View 2 chunks +2 lines, -37 lines 0 comments Download
D pkg/polymer/test/linter_test.dart View 1 chunk +0 lines, -421 lines 0 comments Download
M pkg/polymer/test/run.sh View 1 chunk +10 lines, -116 lines 0 comments Download
D pkg/polymer/test/run_all.dart View 1 chunk +0 lines, -68 lines 2 comments Download
D pkg/polymer/test/testing.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D pkg/polymer/test/utils_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
the goal here is to get one reliable way to run tests, and in particular ...
7 years, 3 months ago (2013-09-10 05:30:34 UTC) #1
Siggi Cherem (dart-lang)
lgtm. Quite the conflicts with the files I'm deleting/moving =) https://codereview.chromium.org/24077003/diff/3001/pkg/polymer/test/run_all.dart File pkg/polymer/test/run_all.dart (left): https://codereview.chromium.org/24077003/diff/3001/pkg/polymer/test/run_all.dart#oldcode47 ...
7 years, 3 months ago (2013-09-10 20:52:00 UTC) #2
Jennifer Messerly
Thanks! https://codereview.chromium.org/24077003/diff/3001/pkg/polymer/test/run_all.dart File pkg/polymer/test/run_all.dart (left): https://codereview.chromium.org/24077003/diff/3001/pkg/polymer/test/run_all.dart#oldcode47 pkg/polymer/test/run_all.dart:47: addGroup('transform/all_phases_test.dart', all_phases_test.main); On 2013/09/10 20:52:00, Siggi Cherem (dart-lang) ...
7 years, 3 months ago (2013-09-10 21:17:10 UTC) #3
Jennifer Messerly
7 years, 3 months ago (2013-09-10 21:24:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698