Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 24076005: fix observing superclass fields, issue 13255 (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix observing superclass fields, issue 13255 this was previously blocked by a mirrors bug, but no longer. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=27402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M pkg/observe/lib/src/observable.dart View 2 chunks +17 lines, -13 lines 0 comments Download
M pkg/observe/test/observe_test.dart View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 3 months ago (2013-09-11 20:27:59 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 3 months ago (2013-09-11 20:28:46 UTC) #2
Jennifer Messerly
7 years, 3 months ago (2013-09-11 20:34:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698