Expose field data, use class id, and merge all collections into "objects"

Expose field data, use class id, and merge all collections into "objects"

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27684

[siva, 2013-09-17 17:25:33]

lgtm

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:2937: user_visible_class_name =
String::Handle(UserVisibleName()).ToCString();
internal_class_name and user_visible_class_name are overriden right away why
initialize them to "<no name>" first?

maybe:

const char* internal_class_name = String::Handle(Name()).ToCString();
const char* user_visible_class_name = ...

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:2968: functions_array.AddValue(function);
Do we only want to list the user defined functions here or all the functions
including the implicit ones?

VM developers would like to see all the functions, I am not sure about external
users. Maybe we could include some description making it clear that these are
implicit functions generated by the VM

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:5459: if (ref) return;
Not sure if we have used this style elsewhere.

if (ref) {
  return;
}

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service....
runtime/vm/service.cc:223: REQUIRE_COLLECTION_ID("classes");
We have already checked and processed for
'if (js->num_arguments() == 1)' above, this macro seems to check again.

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service....
runtime/vm/service.cc:229: obj.PrintToJSONStream(js, false);
You could do this as:

Object::null_object().PrintToJSONStream(js, false);

[Cutch, 2013-09-19 23:57:38]

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:2937: user_visible_class_name =
String::Handle(UserVisibleName()).ToCString();
On 2013/09/17 17:25:33, siva wrote:
> internal_class_name and user_visible_class_name are overriden right away why
> initialize them to "<no name>" first?
> 
> maybe:
> 
> const char* internal_class_name = String::Handle(Name()).ToCString();
> const char* user_visible_class_name = ...

Done.

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:2968: functions_array.AddValue(function);
On 2013/09/17 17:25:33, siva wrote:
> Do we only want to list the user defined functions here or all the functions
> including the implicit ones?
> 
> VM developers would like to see all the functions, I am not sure about
external
> users. Maybe we could include some description making it clear that these are
> implicit functions generated by the VM

We should provide the complete list of functions and mark them as user or
implicit, etc. I will revisit this in a future CL.

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:5459: if (ref) return;
On 2013/09/17 17:25:33, siva wrote:
> Not sure if we have used this style elsewhere.
> 
> if (ref) {
>   return;
> }

Done.

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service....
runtime/vm/service.cc:223: REQUIRE_COLLECTION_ID("classes");
On 2013/09/17 17:25:33, siva wrote:
> We have already checked and processed for
> 'if (js->num_arguments() == 1)' above, this macro seems to check again.

Done.

https://chromiumcodereview.appspot.com/24075002/diff/3001/runtime/vm/service....
runtime/vm/service.cc:229: obj.PrintToJSONStream(js, false);
On 2013/09/17 17:25:33, siva wrote:
> You could do this as:
> 
> Object::null_object().PrintToJSONStream(js, false);

Done.

[Cutch, 2013-09-20 01:00:21]

Committed patchset #3 manually as r27684 (presubmit successful).