Issue 2407473002: Look at e.path where available (M55+)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2407473002: Look at e.path where available (M55+) (Closed)

Created:
4 years, 2 months ago by Pam (message me for reviews)

Modified:
4 years, 2 months ago

Reviewers:
ojan

Target Ref:
refs/heads/1.5.1

Visibility:
Public.

Look at e.path where available (M55+) With the fix to e.path for events on Window (issue 645527), coming in M55, look there instead of document.activeElement when possible. This fix is based on the currently released v1.5.1 of the extension, since the options and popup pages are still waiting for final UI. BUG=653993, 645527 R=ojan@chromium.org Committed: https://chromium.googlesource.com/chromium/extensions-by-google/c2b68a8a18bd8f6cca755c40473a460470b13a72

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	go-back-with-backspace/content_script.js	View		1 chunk	+12 lines, -8 lines	0 comments	Download
	M	go-back-with-backspace/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Pam (message me for reviews)

4 years, 2 months ago (2016-10-07 22:49:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2b68a8a18bd8f6cca755c40473a460470b13a72 (presubmit successful).