Issue 24073002: Emit error on default values in typedefs.

Issue 24073002: Emit error on default values in typedefs. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit error on default values in typedefs. BUG=dartbug.com/12801,dartbug.com/12802 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27324

Patch Set 2 : Fix warning example. #

Patch Set 3 : Add a test for named arguments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -19 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		5 chunks	+17 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/function_type_alias7_test.dart	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/24073002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/24073002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode425 sdk/lib/_internal/compiler/implementation/warnings.dart:425: typedef void F([int arg: 0]); Wrong syntax: It ...

7 years, 3 months ago (2013-09-09 13:23:17 UTC) #2

karlklose

Thanks, Johnni. https://codereview.chromium.org/24073002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/24073002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode425 sdk/lib/_internal/compiler/implementation/warnings.dart:425: typedef void F([int arg: 0]); On 2013/09/09 ...

7 years, 3 months ago (2013-09-09 13:38:56 UTC) #3

karlklose

7 years, 3 months ago (2013-09-10 08:42:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27324 (presubmit successful).

Expand Messages | Collapse Messages