Issue 24046003: Fix TODO in polymer _shimCss, remove package:js dependency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24046003: Fix TODO in polymer _shimCss, remove package:js dependency (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly

Modified:
7 years, 3 months ago

Reviewers:
terry, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix TODO in polymer _shimCss, remove package:js dependency additional fixes: * rename to match Polymer * move to happen in the "declaration" phase, not instance initialization R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=27501

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -47 lines)			Patch
M	pkg/polymer/lib/polymer_element.dart	View	4 chunks	+21 lines, -27 lines	1 comment	Download
M	pkg/polymer/lib/src/transform/polyfill_injector.dart	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	pkg/polymer/pubspec.yaml	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/polymer/test/transform/all_phases_test.dart	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	pkg/polymer/test/transform/common.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/polymer/test/transform/polyfill_injector_test.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/24046003/diff/4001/pkg/polymer/lib/polymer_element.dart File pkg/polymer/lib/polymer_element.dart (right): https://codereview.chromium.org/24046003/diff/4001/pkg/polymer/lib/polymer_element.dart#newcode157 pkg/polymer/lib/polymer_element.dart:157: var templateNode = declaration.query('template'); changed because polymer uses query: ...

7 years, 3 months ago (2013-09-13 17:49:43 UTC) #2

Jennifer Messerly

7 years, 3 months ago (2013-09-13 20:36:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27501 (presubmit successful).

Expand Messages | Collapse Messages