Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 240443007: VM: Fix TypedefMirror.isPrivate and TypeVariableMirror.isPrivate. (Closed)

Created:
6 years, 8 months ago by rmacnak
Modified:
6 years, 7 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Fix TypedefMirror.isPrivate and TypeVariableMirror.isPrivate. BUG=http://dartbug.com/18271 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=35758

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 4 chunks +2 lines, -4 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/private_types_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
6 years, 8 months ago (2014-04-17 17:01:04 UTC) #1
gbracha
test lgtm
6 years, 8 months ago (2014-04-17 17:50:28 UTC) #2
rmacnak
6 years, 7 months ago (2014-05-05 17:33:02 UTC) #3
siva
lgtm
6 years, 7 months ago (2014-05-05 18:21:17 UTC) #4
rmacnak
6 years, 7 months ago (2014-05-05 19:46:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r35758 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698