Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 240423004: Version 1.3.2 (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Version 1.3.2 Update dartium deps to fix wrong branch point for 1847_stable R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=35119

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M dart/tools/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M deps/dartium.deps/DEPS View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 8 months ago (2014-04-16 17:49:38 UTC) #1
Leaf
lgtm
6 years, 8 months ago (2014-04-16 17:53:41 UTC) #2
ricow1
Committed patchset #1 manually as r35119 (presubmit successful).
6 years, 8 months ago (2014-04-16 17:57:56 UTC) #3
ricow1
6 years, 8 months ago (2014-04-16 18:20:02 UTC) #4
Message was sent while issue was closed.
I did a follow up to fix

https://codereview.chromium.org/240423004/diff/1/deps/dartium.deps/DEPS
File deps/dartium.deps/DEPS (right):

https://codereview.chromium.org/240423004/diff/1/deps/dartium.deps/DEPS#newcode1
deps/dartium.deps/DEPS:1: 1;2cimport gclient_utils
this was pretty stupid by me

Powered by Google App Engine
This is Rietveld 408576698