Fix failure when linting getters (issue 27545)

Fix failure when linting getters (issue 27545)

R=pquitslund@google.com

Committed: https://github.com/dart-lang/linter/commit/aca98436fa1223b3824ea4f5e476bae52daffab2

[Brian Wilkerson, 2016-10-07 17:29:31]

brianwilkerson@google.com changed reviewers:
+ alexeidiaz@google.com

[pquitslund, 2016-10-07 20:04:14]

pquitslund@google.com changed reviewers:
+ pquitslund@google.com

[pquitslund, 2016-10-07 20:04:14]

lgtm

[Brian Wilkerson, 2016-10-07 20:48:50]

Description was changed from

==========
Fix failure when linting getters (issue 27545)
==========

to

==========
Fix failure when linting getters (issue 27545)

R=pquitslund@google.com

Committed:
https://github.com/dart-lang/linter/commit/aca98436fa1223b3824ea4f5e476bae52d...
==========

[Brian Wilkerson, 2016-10-07 20:48:51]

Committed patchset #1 (id:1) manually as
aca98436fa1223b3824ea4f5e476bae52daffab2 (presubmit successful).

[Alexei Diaz, 2016-10-07 20:49:39]

lgtm

Thank you!

Is this because of the bug I found when writing the class names lint?

[Brian Wilkerson, 2016-10-07 20:52:03]

I'm not sure what bug you're referring to. This is due to the fact that getters,
which are represented as instances of MethodDeclaration, do not have a parameter
list, but the code wasn't checking for that case.

[Alexei Diaz, 2016-10-07 20:54:09]

I have been seeing this error on IntelliJ

Dart analysis server, SDK version 1.20.0-dev.10.0, server version 1.17.0, error:
Task failed: GenerateLintsTask for source ...

I wonder if this was the cause. I guess I can confirm by disabling there rule.

[Brian Wilkerson, 2016-10-07 20:55:36]

Probably the same, yes. Check the issue for the stack trace that led to this CL
(https://github.com/dart-lang/sdk/issues/27545).

[Alexei Diaz, 2016-10-07 21:10:50]

It is. I am really sorry, will be more careful in the future.

[Brian Wilkerson, 2016-10-07 21:34:46]

No worries! Everyone makes mistakes, and this is an easy one to make.