Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2402473002: Add ClosureInfo for closures. (Closed)

Created:
4 years, 2 months ago by Harry Terkelsen
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ClosureInfo for closures. This allows us to track closure size, including captured variables, in addition to the function size. R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/205f3edcfa1597f48921ff896fe61769ba75d616

Patch Set 1 #

Patch Set 2 : add docs #

Total comments: 1

Patch Set 3 : update parse test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -27 lines) Patch
M bin/debug_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/info.dart View 1 11 chunks +34 lines, -6 lines 0 comments Download
M lib/json_info_codec.dart View 5 chunks +26 lines, -9 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/hello_world/hello_world.js.info.json View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M test/parse_test.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
https://codereview.chromium.org/2402473002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2402473002/diff/20001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.5.0 i bumped it to 0.5.0 instead of ...
4 years, 2 months ago (2016-10-06 17:18:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years, 2 months ago (2016-10-06 17:28:36 UTC) #3
Harry Terkelsen
4 years, 2 months ago (2016-10-06 17:34:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
205f3edcfa1597f48921ff896fe61769ba75d616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698