Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 24019007: Fix reparsing of function parameters that include type parameters. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)
Modified:
7 years, 3 months ago
Reviewers:
rmacnak, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix reparsing of function parameters that include type parameters. The parser is now properly initializing parsed_function/current_function to make internal lookups work (instead of crashing). BUG= R=hausner@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=27418

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/mirrors/parameter_test.dart View 1 2 chunks +29 lines, -0 lines 0 comments Download
M tests/lib/mirrors/stringify.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Lippautz (Google)
7 years, 3 months ago (2013-09-11 18:22:21 UTC) #1
hausner
LGTM.
7 years, 3 months ago (2013-09-11 20:57:58 UTC) #2
rmacnak
https://codereview.chromium.org/24019007/diff/1/tests/lib/mirrors/parameter_test.dart File tests/lib/mirrors/parameter_test.dart (right): https://codereview.chromium.org/24019007/diff/1/tests/lib/mirrors/parameter_test.dart#newcode157 tests/lib/mirrors/parameter_test.dart:157: ' type = Type(s(S) in s(C)))]', We should probably ...
7 years, 3 months ago (2013-09-11 21:17:21 UTC) #3
Michael Lippautz (Google)
Note: dart2js is not affected, since they don't use it, yet. https://codereview.chromium.org/24019007/diff/1/tests/lib/mirrors/parameter_test.dart File tests/lib/mirrors/parameter_test.dart (right): ...
7 years, 3 months ago (2013-09-11 21:52:41 UTC) #4
rmacnak
lgtm
7 years, 3 months ago (2013-09-12 01:05:23 UTC) #5
Michael Lippautz (Google)
7 years, 3 months ago (2013-09-12 01:06:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r27418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698