Issue 24008002: Merge tests for dart2js and VM using multi-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24008002: Merge tests for dart2js and VM using multi-tests. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)

Modified:
7 years, 3 months ago

Reviewers:
ahe, rmacnak

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Merge tests for dart2js and VM using multi-tests. BUG= R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=27633

Patch Set 2 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -170 lines)			Patch
M	tests/lib/lib.status	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
D	tests/lib/mirrors/equality_dart2js_test.dart	View		1 chunk	+0 lines, -112 lines	0 comments	Download
M	tests/lib/mirrors/equality_test.dart	View		3 chunks	+14 lines, -5 lines	0 comments	Download
D	tests/lib/mirrors/parameter_dart2js_test.dart	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	tests/lib/mirrors/parameter_test.dart	View	1	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

https://codereview.chromium.org/24008002/diff/1/tests/lib/mirrors/equality_test.dart File tests/lib/mirrors/equality_test.dart (right): https://codereview.chromium.org/24008002/diff/1/tests/lib/mirrors/equality_test.dart#newcode98 tests/lib/mirrors/equality_test.dart:98: {'currentMirrorSystem().voidType' : currentMirrorSystem().voidType}, /// 01: ok Please, have mercy ...

7 years, 3 months ago (2013-09-05 22:49:49 UTC) #1

Michael Lippautz (Google)

7 years, 3 months ago (2013-09-18 19:50:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27633 (presubmit successful).

Expand Messages | Collapse Messages

Issue 24008002: Merge tests for dart2js and VM using multi-tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages