Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 23996003: Be consistent with number scanning (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Be consistent with number scanning If 1.e+2 is interpreted as an integer literal followed by other tokens, then so should 1e be interpreted as an integer literal followed by identifier e. Committed: https://code.google.com/p/dart/source/detail?r=27218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/scanner.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
TBR=iposva Sorry to check the number scanning fix in as two changes. This slipped my ...
7 years, 3 months ago (2013-09-05 22:27:42 UTC) #1
hausner
Committed patchset #1 manually as r27218 (presubmit successful).
7 years, 3 months ago (2013-09-05 22:27:55 UTC) #2
Ivan Posva
7 years, 3 months ago (2013-09-05 23:16:50 UTC) #3
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698