Support declaring and lazy transformers in pub.

Support declaring and lazy transformers in pub.

R=rnystrom@google.com
BUG=16998
RELNOTE=User-defined lazy transformers will be lazy when using "pub serve".

Committed: https://code.google.com/p/dart/source/detail?r=35139

[Bob Nystrom, 2014-04-16 16:20:59]

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
File sdk/lib/_internal/pub/asset/dart/serialize/transform.dart (right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:25: Future
handleMessage(message)) {
Since handleMessage is specifically for handling methods, how about putting the
message[type] checking here and pass in a map of methodName->callback. Like:

var handler = methodHandlers[message['type']];
if (handler != null) return handler();

See below...

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:47: method =
transform.logger.error;
Seems like a map would be simpler here.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:65: }, (message) {
...and then here, do:

{
  'getInput': () => return transform.getInput(deserializeId(message['id']))
           .then((asset) => serializeAsset(asset)),
  'addOutput': () => ...
}

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:124: /// Creates a
transform from a serializable map sent from the host isolate.
"serializable" -> "serialized".

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/foreign_transformer.dart (right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/foreign_transformer.dart:88: if
(map['type'] == 'TransformerGroup') return new _ForeignGroup(id, map);
How about:

switch (map['type']) { ... }

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers.dart
(right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers.dart:71:
d.file("lazy.dart", LAZY_TRANSFORMER),
Document that we need a lazy transformer before the declaring one so that it
isn't just run eagerly.

[nweiz, 2014-04-16 20:28:21]

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
File sdk/lib/_internal/pub/asset/dart/serialize/transform.dart (right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:25: Future
handleMessage(message)) {
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> Since handleMessage is specifically for handling methods, how about putting
the
> message[type] checking here and pass in a map of methodName->callback. Like:
> 
> var handler = methodHandlers[message['type']];
> if (handler != null) return handler();
> 
> See below...

Done.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:47: method =
transform.logger.error;
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> Seems like a map would be simpler here.

Done.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:65: }, (message) {
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> ...and then here, do:
> 
> {
>   'getInput': () => return transform.getInput(deserializeId(message['id']))
>            .then((asset) => serializeAsset(asset)),
>   'addOutput': () => ...
> }

Done.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:124: /// Creates a
transform from a serializable map sent from the host isolate.
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> "serializable" -> "serialized".

Done.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/foreign_transformer.dart (right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/foreign_transformer.dart:88: if
(map['type'] == 'TransformerGroup') return new _ForeignGroup(id, map);
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> How about:
> 
> switch (map['type']) { ... }

Done.

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/test/s...
File
sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers.dart
(right):

https://codereview.chromium.org/239853002/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers.dart:71:
d.file("lazy.dart", LAZY_TRANSFORMER),
On 2014/04/16 16:21:00, Bob Nystrom wrote:
> Document that we need a lazy transformer before the declaring one so that it
> isn't just run eagerly.

Done.

[Bob Nystrom, 2014-04-16 22:28:41]

LGTM!

We should send a note to misc explaining the new feature.

https://codereview.chromium.org/239853002/diff/20001/sdk/lib/_internal/pub/as...
File sdk/lib/_internal/pub/asset/dart/serialize/transform.dart (right):

https://codereview.chromium.org/239853002/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:21: /// serialized
transform. [handleMessage] handles additional methods that differ
Update the doc comment.

https://codereview.chromium.org/239853002/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:43:
}[message['level']];
<3

[nweiz, 2014-04-16 23:03:10]

https://codereview.chromium.org/239853002/diff/20001/sdk/lib/_internal/pub/as...
File sdk/lib/_internal/pub/asset/dart/serialize/transform.dart (right):

https://codereview.chromium.org/239853002/diff/20001/sdk/lib/_internal/pub/as...
sdk/lib/_internal/pub/asset/dart/serialize/transform.dart:21: /// serialized
transform. [handleMessage] handles additional methods that differ
On 2014/04/16 22:28:41, Bob Nystrom wrote:
> Update the doc comment.

Done.

[nweiz, 2014-04-16 23:03:50]

Committed patchset #4 manually as r35139 (presubmit successful).