Fill in type arguments when creating an object from the mirrors or embedding API.

Fill in type arguments when creating an object from the mirrors or embedding API.

BUG=http://dartbug.com/13186
BUG=http://dartbug.com/12921
R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27417

[rmacnak, 2013-09-11 21:10:21]

https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (left):

https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc#oldcode33
runtime/lib/mirrors.cc:33: static RawAbstractType* RawTypeOfClass(const Class&
cls) {
Moved to a method on Class because it is also needed by the embedding API.

https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h#newcode708
runtime/vm/object.h:708: RawType* BasicType() const;
Perhaps ImplicitInstantiationType?

[regis, 2013-09-11 21:37:40]

https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1167: new_object.SetTypeArguments(type_arguments);
Who is checking that this type_argument vector has the correct length, that it
has been finalized and bound checked?

https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h#newcode709
runtime/vm/object.h:709: 
This is not the way to do it. You need to finalize the type argument vector.
Your 'basic type' is an unfinalized type with a null type argument vector. The
vector may not be null anymore after finalization. Consider
class C<T> extends List<int>.
new C() results in an instance with a type argument vector of [int, dynamic].

or

class D extends List<int>

new C() results in an instance with a type argument vector of [int].

You cannot finalize the vector here. You need to do it before calling the
constructor in the API code.

[rmacnak, 2013-09-12 00:03:26]

Renamed BasicType to RareType. Ensured that all ClassMirrors have a Type,
regardless of whether they expose it.

On 2013/09/11 21:37:40, regis wrote:
> https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc
> File runtime/lib/mirrors.cc (right):
> 
>
https://codereview.chromium.org/23983026/diff/1/runtime/lib/mirrors.cc#newcod...
> runtime/lib/mirrors.cc:1167: new_object.SetTypeArguments(type_arguments);
> Who is checking that this type_argument vector has the correct length, that it
> has been finalized and bound checked?

As discussed offline, this type is derived from other types, not from
user-provided arguments.

> https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h
> File runtime/vm/object.h (right):
> 
> https://codereview.chromium.org/23983026/diff/1/runtime/vm/object.h#newcode709
> runtime/vm/object.h:709: 
> This is not the way to do it. You need to finalize the type argument vector.
> Your 'basic type' is an unfinalized type with a null type argument vector. The
> vector may not be null anymore after finalization. Consider
> class C<T> extends List<int>.
> new C() results in an instance with a type argument vector of [int, dynamic].
> 
> or
> 
> class D extends List<int>
> 
> new C() results in an instance with a type argument vector of [int].
> 
> You cannot finalize the vector here. You need to do it before calling the
> constructor in the API code.

[regis, 2013-09-12 00:30:06]

LGTM

https://codereview.chromium.org/23983026/diff/7001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23983026/diff/7001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:1516: Type& type = Type::Handle(Type::New(*this,
const Type& type ...

[rmacnak, 2013-09-12 00:46:07]

On 2013/09/12 00:30:06, regis wrote:
> LGTM
> 
> https://codereview.chromium.org/23983026/diff/7001/runtime/vm/object.cc
> File runtime/vm/object.cc (right):
> 
>
https://codereview.chromium.org/23983026/diff/7001/runtime/vm/object.cc#newco...
> runtime/vm/object.cc:1516: Type& type = Type::Handle(Type::New(*this,
> const Type& type ...

Done.

[rmacnak, 2013-09-12 00:48:30]

Committed patchset #3 manually as r27417 (presubmit successful).