Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 23979004: Check for uninitialized constant variables. (Closed)

Created:
7 years, 3 months ago by Johnni Winther
Modified:
7 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Kathy Walrath, lukechurch
Visibility:
Public.

Description

Check for uninitialized constant variables. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27623

Patch Set 1 #

Patch Set 2 : Updated error text. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
tests/co19/co19-dart2dart.status View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
tests/co19/co19-dart2js.status View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years, 3 months ago (2013-09-18 14:15:43 UTC) #1
Johnni Winther
7 years, 3 months ago (2013-09-18 14:31:34 UTC) #2
karlklose
LGTM.
7 years, 3 months ago (2013-09-18 15:02:41 UTC) #3
Johnni Winther
7 years, 3 months ago (2013-09-18 15:11:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r27623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698