Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 23967004: Be sure to enter monitor before notifying, in file_system_watcher_macos. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Be sure to enter monitor before notifying, in file_system_watcher_macos. BUG=https://code.google.com/p/dart/issues/detail?id=13065 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27178

Patch Set 1 #

Patch Set 2 : Remove test from status-file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/bin/file_system_watcher_macos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-05 07:28:45 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-05 07:29:30 UTC) #2
Anders Johnsen
Status-file change, PTAL.
7 years, 3 months ago (2013-09-05 07:31:10 UTC) #3
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-05 07:41:07 UTC) #4
Anders Johnsen
7 years, 3 months ago (2013-09-05 08:14:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698