Issue 239613002: Fix *ServerSocket's handling of zones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239613002: Fix *ServerSocket's handling of zones. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse, floitsch, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix *ServerSocket's handling of zones. A stream's zone is the one it has when listening to. Use that, and not the one active when creating the socket. BUG=https://code.google.com/p/dart/issues/detail?id=17468 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=35071

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -9 lines)			Patch
	M	runtime/bin/socket_patch.dart	View		2 chunks	+10 lines, -9 lines	0 comments	Download
	M	tests/standalone/io/http_server_test.dart	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r35071 (presubmit successful).

6 years, 8 months ago (2014-04-15 18:44:39 UTC) #3

kasperl

6 years, 8 months ago (2014-04-18 11:15:39 UTC) #4

Message was sent while issue was closed.

Is this something we should consider merging to the 1.3 release branch after
we've had this on the dev channel to get test coverage?

Expand Messages | Collapse Messages