Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 239603004: pkg/scheduled_test fixed shelf dependency (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/scheduled_test fixed shelf dependency Also fixed a couple of analyzer warnings R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35090

Patch Set 1 #

Patch Set 2 : version bump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/scheduled_test/CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/scheduled_test/pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 8 months ago (2014-04-15 21:56:29 UTC) #1
nweiz
These analyzer errors should already have been fixed. Have you synced recently?
6 years, 8 months ago (2014-04-15 21:57:55 UTC) #2
nweiz
lgtm
6 years, 8 months ago (2014-04-15 21:59:37 UTC) #3
kevmoo
6 years, 8 months ago (2014-04-15 22:01:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r35090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698