Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 239573002: Split off a Driver class from analysis server's HttpAnalysisServer. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split off a Driver class from analysis server's HttpAnalysisServer. The Driver class sits above the HttpAnalysisServer, parsing command line options and deciding how the sever should be run. With this change, HttpAnalysisServer now contains only http-specific code. R=brianwilkerson@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=35075

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -71 lines) Patch
M pkg/analysis_server/bin/server.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/analysis_server/lib/driver.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/http_server.dart View 5 chunks +9 lines, -68 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Paul Berry
Note: http_server.dart probably belongs in lib/src/ now, since it's no longer used by bin/server.dart so ...
6 years, 8 months ago (2014-04-15 18:03:00 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/239573002/diff/1/pkg/analysis_server/lib/http_server.dart File pkg/analysis_server/lib/http_server.dart (right): https://codereview.chromium.org/239573002/diff/1/pkg/analysis_server/lib/http_server.dart#newcode33 pkg/analysis_server/lib/http_server.dart:33: HttpAnalysisServer(SocketServer this.socketServer); nit: The standard practice is to ...
6 years, 8 months ago (2014-04-15 18:16:29 UTC) #2
jwren
LGTM
6 years, 8 months ago (2014-04-15 18:17:15 UTC) #3
Paul Berry
6 years, 8 months ago (2014-04-15 19:55:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698