Fix bug in inferrer for the computation of callers: we need to keep track of what is the called nod…

Fix bug in inferrer for the computation of callers: we need to keep track of what is the called node to ensure another call does not accidentally remove a caller.

The bug was in the following code:
Iterable<Element> untypedTargets = allFuctions.filter(selector.asUntyped);
Iterable<Element> typedTargets = allFuctions.filter(selector);

for (callee in untypedTargets) {
  if (!typedTargets.contains(callee)) {
    callee.removeCall(caller);
  } else {
    callee.addCall(caller);
  }
}

The "removeCall" here is not correct because the relation caller-> callee could have been made by another call, with the same selector name but a different typedTargets set.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27233

[kasperl, 2013-09-06 08:22:33]

LGTM!

https://codereview.chromium.org/23956007/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/23956007/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:196:
callers[caller].remove(node);
I'd put callers[caller] in a local variable.

[ngeoffray, 2013-09-06 08:42:13]

Thanks Kasper.

https://codereview.chromium.org/23956007/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/23956007/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:196:
callers[caller].remove(node);
On 2013/09/06 08:22:33, kasperl wrote:
> I'd put callers[caller] in a local variable.

Done.

[ngeoffray, 2013-09-06 08:43:11]

Committed patchset #2 manually as r27233 (presubmit successful).