Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 23956004: Run testReadAsText wrapped in createTempDirectory, as it uses the shared temp directory. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run testReadAsText wrapped in createTempDirectory, as it uses the shared temp directory. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27180

Patch Set 1 #

Patch Set 2 : Marking more tests as async. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tests/standalone/io/file_test.dart View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-05 08:46:22 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-05 08:46:39 UTC) #2
Anders Johnsen
PTAL, found a few more...
7 years, 3 months ago (2013-09-05 08:51:29 UTC) #3
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-05 08:52:21 UTC) #4
Anders Johnsen
7 years, 3 months ago (2013-09-05 08:53:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698