Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 23953004: Throw FileExceptions when in File when reading as String and decoding fails. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Throw FileExceptions when in File when reading as String and decoding fails. BUG=https://code.google.com/p/dart/issues/detail?id=13199 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -4 lines) Patch
M sdk/lib/io/file_impl.dart View 1 chunk +18 lines, -4 lines 0 comments Download
A tests/standalone/io/file_read_encoded_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-10 08:46:38 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-10 09:25:13 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-10 11:14:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698