Merge two language/scope_ tests

Merge two language/scope_ tests

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=27108

[kustermann, 2013-09-04 09:28:42]

LGTM with comment

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
File tests/language/scope_variable_test.dart (right):

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
tests/language/scope_variable_test.dart:15: Expect.equals(true, c == null);
I'd use one of these two instead:

  Expect.isTrue(c == null)
  Expect.equals(null, c)

It's kind of strange to do 'Expect.equals(true, c == null)'.

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
tests/language/scope_variable_test.dart:38: var a = 5;  /// 01: compile-time
error
I wasn't aware that this is supposed to result in a compile-time error.
Good to know!

[Søren Gjesse, 2013-09-04 10:16:16]

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
File tests/language/scope_variable_test.dart (right):

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
tests/language/scope_variable_test.dart:15: Expect.equals(true, c == null);
On 2013/09/04 09:28:42, kustermann wrote:
> I'd use one of these two instead:
> 
>   Expect.isTrue(c == null)
>   Expect.equals(null, c)
> 
> It's kind of strange to do 'Expect.equals(true, c == null)'.

Done (I just copied some old code). Ended up using Expect.isNull.

[Søren Gjesse, 2013-09-04 10:17:13]

Committed patchset #2 manually as r27108 (presubmit successful).

[kustermann, 2013-09-04 10:19:16]

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
File tests/language/scope_variable_test.dart (right):

https://codereview.chromium.org/23944004/diff/1/tests/language/scope_variable...
tests/language/scope_variable_test.dart:15: Expect.equals(true, c == null);
On 2013/09/04 10:16:16, Søren Gjesse wrote:
> On 2013/09/04 09:28:42, kustermann wrote:
> > I'd use one of these two instead:
> > 
> >   Expect.isTrue(c == null)
> >   Expect.equals(null, c)
> > 
> > It's kind of strange to do 'Expect.equals(true, c == null)'.
> 
> Done (I just copied some old code). Ended up using Expect.isNull.

'Expect.isNull' is even better in this case.

My comment was ment to be general: a few lines down we've the same
'Expect.equals()'.