Issue 239433012: Detect and warn about missing scripts (rather than fail during the build)

Issue 239433012: Detect and warn about missing scripts (rather than fail during the build) (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Detect and warn about missing scripts (rather than fail during the build) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35160

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -28 lines)			Patch
M	pkg/polymer/lib/src/build/import_inliner.dart	View		4 chunks	+26 lines, -7 lines	0 comments	Download
M	pkg/polymer/lib/src/build/script_compactor.dart	View	1	4 chunks	+33 lines, -16 lines	0 comments	Download
M	pkg/polymer/test/build/code_extractor.dart	View		2 chunks	+53 lines, -0 lines	0 comments	Download
M	pkg/polymer/test/build/import_inliner_test.dart	View		4 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/build/script_compactor_test.dart	View	1	3 chunks	+53 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/239433012/diff/60001/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (right): https://codereview.chromium.org/239433012/diff/60001/pkg/polymer/lib/src/build/script_compactor.dart#newcode160 pkg/polymer/lib/src/build/script_compactor.dart:160: var libsToLoad = [new AssetId('polymer', 'lib/polymer.dart')] based on ...

6 years, 8 months ago (2014-04-18 00:53:33 UTC) #2

Siggi Cherem (dart-lang)

thx! https://codereview.chromium.org/239433012/diff/60001/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (right): https://codereview.chromium.org/239433012/diff/60001/pkg/polymer/lib/src/build/script_compactor.dart#newcode160 pkg/polymer/lib/src/build/script_compactor.dart:160: var libsToLoad = [new AssetId('polymer', 'lib/polymer.dart')] On 2014/04/18 ...

6 years, 8 months ago (2014-04-18 01:05:16 UTC) #3

Siggi Cherem (dart-lang)

6 years, 8 months ago (2014-04-18 01:43:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35160 (presubmit successful).

Expand Messages | Collapse Messages