Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Issue 23943003: Remove dart2js skips that have bogus reasons for skipping. (Closed)

Created:
7 years, 3 months ago by ricow1
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther, ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove dart2js skips that have bogus reasons for skipping. Issue 4016 seems invalid/assume stalled (but is still open) The suppression for non IE browsers seems bogus as well. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tests/html/html.status View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
7 years, 3 months ago (2013-09-04 11:07:25 UTC) #1
kasperl
LGTM! Thanks, Rico.
7 years, 3 months ago (2013-09-04 11:15:45 UTC) #2
ricow1
7 years, 3 months ago (2013-09-04 11:33:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698