Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 23943002: Fix dart2analyzer warnings, and mark a test as fail because of a false warning in dartanalyzer. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix dart2analyzer warnings, and mark a test as fail because of a false warning in dartanalyzer. Committed: https://code.google.com/p/dart/source/detail?r=27097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #1 manually as r27097 (presubmit successful).
7 years, 3 months ago (2013-09-04 07:27:25 UTC) #1
ngeoffray
TBR
7 years, 3 months ago (2013-09-04 07:27:39 UTC) #2
Johnni Winther
7 years, 3 months ago (2013-09-04 07:33:54 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698