Issue 23934007: Handle reading upper-case placeholders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23934007: Handle reading upper-case placeholders (Closed)

Created:
7 years, 3 months ago by Alan Knight

Modified:
7 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle reading upper-case placeholders R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27437

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	pkg/intl/lib/src/intl_message.dart	View		1 chunk	+22 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/23934007/diff/1/pkg/intl/lib/src/intl_message.dart File pkg/intl/lib/src/intl_message.dart (right): https://codereview.chromium.org/23934007/diff/1/pkg/intl/lib/src/intl_message.dart#newcode244 pkg/intl/lib/src/intl_message.dart:244: * Create a substitution based on the name ...

7 years, 3 months ago (2013-09-12 00:52:19 UTC) #2

Alan Knight

7 years, 3 months ago (2013-09-12 17:09:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27437 (presubmit successful).

Expand Messages | Collapse Messages