Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 239333006: Make the http portion of the analysis server optional. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the http portion of the analysis server optional. If no "--port" option is supplied, the analysis server won't start up an http server, and it will only communicate with the client over stdio. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M pkg/analysis_server/lib/driver.dart View 1 chunk +17 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-16 17:37:34 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-16 17:51:26 UTC) #2
Paul Berry
6 years, 8 months ago (2014-04-16 20:03:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698