Adds object pool, LoadImmediate, and LoadObject to ARM64.

Adds object pool, LoadImmediate, and LoadObject to ARM64.

Also enables many object tests.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35109

[zra, 2014-04-15 22:52:07]

Much of the object pool code I was able to pull from x64.

[regis, 2014-04-15 23:37:03]

LGTM

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.cc
File runtime/vm/assembler_arm64.cc (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.c...
runtime/vm/assembler_arm64.cc:386: movn(reg, ~h0, 0);
OK, I see now why you changed the formal type to uint16_t.

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.c...
runtime/vm/assembler_arm64.cc:407: bool initizlized = false;
initialized, here and 6 mores times below. Getting tired? :-)

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.h
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:299: } else if (!IsImmLogical(imm, sz, op)) {
So, what is the returned op->type_ if IsImmLogical(imm, sz, op) is true?
I would not negate this condition, add an else, and be explicit about the
returned op->type_.

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:490: void movk(Register rd, uint16_t imm, int
hw_idx) {
Changed your mind? :-)

https://codereview.chromium.org/239303008/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/object_test.cc#ne...
runtime/vm/object_test.cc:2995: #if !defined(TARGET_ARCH_ARM64)
I would add a TODO(zra) here and below

[zra, 2014-04-16 15:48:16]

Thanks!

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.cc
File runtime/vm/assembler_arm64.cc (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.c...
runtime/vm/assembler_arm64.cc:407: bool initizlized = false;
On 2014/04/15 23:37:04, regis wrote:
> initialized, here and 6 mores times below. Getting tired? :-)

The z and a are close together =)

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.h
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:299: } else if (!IsImmLogical(imm, sz, op)) {
On 2014/04/15 23:37:04, regis wrote:
> So, what is the returned op->type_ if IsImmLogical(imm, sz, op) is true?
> I would not negate this condition, add an else, and be explicit about the
> returned op->type_.

Done.

https://codereview.chromium.org/239303008/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/239303008/diff/1/runtime/vm/object_test.cc#ne...
runtime/vm/object_test.cc:2995: #if !defined(TARGET_ARCH_ARM64)
On 2014/04/15 23:37:04, regis wrote:
> I would add a TODO(zra) here and below

Done.

[zra, 2014-04-16 15:48:42]

Committed patchset #2 manually as r35109 (presubmit successful).